Skip to content

🐛 Mobile menu - Show the 'View all' link at the end of submenus - #150

Open
tiagov8 wants to merge 1 commit into
mainfrom
fix/149-mobile-view-all-link
Open

tiagov8 wants to merge 1 commit into
mainfrom
fix/149-mobile-view-all-link

Conversation

@tiagov8

@tiagov8 tiagov8 commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Fixes #149

The mobile menu now shows each submenu's "View all" link, such as View all SSW services → at the end of Services, the same as desktop.

What changed

  • MobileMenu.tsx now passes the menu group's viewAll to SubMenuGroup. Desktop (MenuItemWithSubmenu.tsx) already did this; mobile left it out, so SubMenuGroup never drew the link.
  • Bumped the version to 4.14.1 for the release.
image

Risky areas

  • Every submenu with a viewAll setting on mobile. They'll all show the link now, not only Services. Tapping it closes the menu through the existing MenuContextProvider, the same as other links.

🤖 Changes made by Claude Opus 5.5 via Claude Code

Desktop passes the menu group's viewAll to SubMenuGroup, but the mobile menu didn't, so links like 'View All SSW Services' never appeared on mobile. Fixes #149

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tiagov8 tiagov8 self-assigned this Nov 13, 2026
@tiagov8
tiagov8 requested a review from 0xharkirat November 13, 2026 23:14
@tiagov8

tiagov8 commented Nov 13, 2026

Copy link
Copy Markdown
Member Author

There's no staging slot for this repo, so to check it locally:

  1. Check out this branch, then run pnpm install and npx vite --host 127.0.0.1. Using 127.0.0.1 makes the demo load the real menu from ssw.com.au; on localhost it looks for /api/get-megamenu locally and gets nothing.
  2. Open http://127.0.0.1:5173 at mobile width, open the menu, and tap Services.
  3. Scroll to the bottom. View all SSW services → should be there and go to /consulting.

🤖 Comment written by Claude Opus 5.5 via Claude Code

@tiagov8

tiagov8 commented Nov 13, 2026

Copy link
Copy Markdown
Member Author

@joshbermanssw @Aibono1225 you published the last MegaMenu releases, so tagging you for the release step.

This only reaches ssw.com.au once these three things happen:

  1. Merge this PR.
  2. Publish a GitHub release v4.14.1. That triggers the npm publish.
  3. Update ssw.megamenu to 4.14.1 in SSW.Website. This has to be done by hand, because Dependabot doesn't pick up MegaMenu releases (✨ Investigate why Dpependabot updates do not pick up new Megamenu releases SSW.Website#3514).

🤖 Comment written by Claude Opus 5.5 via Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug - Mobile navigation missing 'View All Services' link

1 participant