Repository navigation
Conversation
Desktop passes the menu group's viewAll to SubMenuGroup, but the mobile menu didn't, so links like 'View All SSW Services' never appeared on mobile. Fixes #149 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
There's no staging slot for this repo, so to check it locally:
🤖 Comment written by Claude Opus 5.5 via Claude Code |
Member
Author
|
@joshbermanssw @Aibono1225 you published the last MegaMenu releases, so tagging you for the release step. This only reaches ssw.com.au once these three things happen:
🤖 Comment written by Claude Opus 5.5 via Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149
The mobile menu now shows each submenu's "View all" link, such as View all SSW services → at the end of Services, the same as desktop.
What changed
MobileMenu.tsxnow passes the menu group'sviewAlltoSubMenuGroup. Desktop (MenuItemWithSubmenu.tsx) already did this; mobile left it out, soSubMenuGroupnever drew the link.4.14.1for the release.Risky areas
viewAllsetting on mobile. They'll all show the link now, not only Services. Tapping it closes the menu through the existingMenuContextProvider, the same as other links.🤖 Changes made by Claude Opus 5.5 via Claude Code