Skip to content

fix: don't let the menu fetch overwrite a host-supplied menu #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isaaclombardssw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: don't let the menu fetch overwrite a host-supplied menu #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions lib/hooks/useMenuItems.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,15 @@ export const useMenuItems = (
menuBarItems,
);

// A host that passes menuBarItems has already rendered the menu it shipped
// with, so fetching would only replace correct data with whatever the API's
// caches are still holding. Only hosts that supply nothing need the fetch.
useEffect(() => {
if (menuBarItems) {
setMenuItems(menuBarItems);
return;
}

refreshData()
.then((data) => {
setMenuItems(data);
Expand All @@ -45,12 +53,6 @@ export const useMenuItems = (
// eslint-disable-next-line no-console
console.error(err);
});
}, []);

useEffect(() => {
if (menuBarItems) {
setMenuItems(menuBarItems);
}
}, [menuBarItems]);

return { menuItems: menuItems || [] };
Expand Down
Loading