Repository navigation
[LSR-40136] Update API PHP Client to 1.10.0 - #41
Merged
Merged
Conversation
HamidVetr-Lightspeed
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API PR: https://github.com/SEOshop/API/pull/1555
Description
Replaces
src/WebshopappApiClient.phpwith the client regenerated fromSEOshop/API(generator/generated/WSAClient.php). The file is generated; do not edit it by hand.Changes
CLIENT_VERSIONgoes from1.9.1to1.10.0.quantity_discounts,withdrawals.eventsandquotesConvert. Their API routes were removed in 2020 (CAM-12037) and 2021 (#757), so calls to them already failed.TypeError/ValueErrorcrashes and deprecations on PHP 8 in file uploads, response handling and error handling. No type declarations were added, and the syntax stays PHP 5.4-compatible.WebshopappApiException('Invalid payload', 100), and an unknown server name throwsWebshopappApiException('Invalid API server.').Class list diff (105 → 105)
Verification
Identical results on PHP 7.4, 8.1, 8.2 and 8.3 across 35 test cases against a mock API, with no warnings or deprecations.
Before merging
SEOshop/APIis merged, and this file matches its output.eventsandquotesConvert, and the version number.After merging: tag
v1.10.0, publish the GitHub release, and check that Packagist shows1.10.0.JIRA
LSR-40136