Skip to content

docs(quality): record the alpine digest refresh in the base-image inventory - #1291

Merged
Rick1330 merged 2 commits into
mainfrom
docs/base-image-inventory-alpine
Nov 21, 2026
Merged

Rick1330 merged 2 commits into
mainfrom
docs/base-image-inventory-alpine

Conversation

@Rick1330

@Rick1330 Rick1330 commented Nov 21, 2026 •

Copy link
Copy Markdown
Owner

What and Why

The alpine final-stage digest moved to f59abe6 in #1191 (proxy) and #1190 (auth), but engineering/quality/base-images.md still pinned the previous 294b683 for both. The inventory is the record that makes the next refresh auditable, so a stale pin there is how an image gets renewed without anyone knowing which digest it replaced.

Tracking issue

Closes #1292

How

Updated the two per-Dockerfile rows and the digest inventory row, keeping the superseded digest as a dated history entry rather than overwriting it.

Testing

npx --yes markdownlint-cli2 engineering/quality/base-images.md — 0 issues in the changed file. The repo-wide run reports two pre-existing MD018 errors in loop-run-log.md, which this change does not touch.

Performance

None — documentation only.

Security

None. Records the digest that is already running.

Migrations / Ops

None.

Docs

This PR is the documentation change.


Devin Review

RetriggerView in GreptileConfidence Score: 5/5

This documentation-only change appears safe to merge.

Summary

Updates engineering/quality/base-images.md to record the Alpine digest already used by auth and proxy.

  • The base-image inventory records the new Alpine digest for auth and proxy.

No new actionable issues found.

Reviews (6) · Last reviewed commit: "docs(quality): correct the alpine versio..." · Reviewed by Greptile

@github-actions github-actions Bot added the area/docs Markdown, MDX, roadmap, ADRs label Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 43be7fca-abbc-4354-b9c0-a4f726027ea2
Commits

Reviewing files that changed from the base of the PR and between 2d2e91d and 38c38b3.

Files selected for processing: 1

  • engineering/quality/base-images.md
Summary

Summary by CodeRabbit

  • Documentation
    • Updated the recorded Alpine base-image digest and pin date for the authentication and proxy service images.

The base-image inventory adds the Alpine 3.24.2 digest pinned on 2026-11-20 and marks the previous digest as superseded. The services/auth and services/proxy final-image records now reference the new digest.

Changes: Alpine digest refresh

Layer / File(s) Summary
Update digest inventory and service records
engineering/quality/base-images.md
The inventory adds the new Alpine digest and marks the previous digest as superseded. The auth and proxy final-image records now use the new digest and pin date.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Possibly related PRs

Merge Risk: Low · previous review 2d2e9

The base-image inventory has inaccurate metadata for the new Alpine digest and a stale image count. This does not change runtime behavior, but it undermines the audit purpose of the file. Fix both before merging.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "docs(quality): record the alpine digest refresh in the base-image inventory" names the main change. The PR updates engineering/quality/base-images.md to record the new alpine digest f59abe6…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description follows the repository template for most sections. It covers What and Why, Tracking issue (Closes #1292), How, Testing, Performance, Security, Migrations/Ops, and Docs. The change is d…
Full details: Title check

Explanation

The title "docs(quality): record the alpine digest refresh in the base-image inventory" names the main change. The PR updates engineering/quality/base-images.md to record the new alpine digest f59abe6 and keeps the superseded digest as history. The title is specific, follows a conventional-commit style, and matches the changeset.

Full details: Description check

Explanation

The description follows the repository template for most sections. It covers What and Why, Tracking issue (Closes #1292), How, Testing, Performance, Security, Migrations/Ops, and Docs. The change is documentation only, and the author states the digest change and its rationale clearly. Two gaps remain. First, the Tracking issue section does not show the required bidirectional link, because the issue body or a comment must reference this PR. Second, the Checklist (Definition of Done) section is missing entirely. The template's Testing checkbox list (unit, integration, manual, and the EXTRACTION_SYSTEM_PROMPT_BATCH cassette clause) is also not marked. The cassette clause does not apply to this docs-only change, so the author should state that it is not applicable. The Greptile review comment reports a P2 finding that the pin dates do not match the git log method, but that is review feedback and not part of the author's description. The description is mostly complete, so the check passes.

Finishing Touches

Fix failing CI checks

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the image row,
A newer Alpine tag now glows.
The old digest rests, superseded,
Auth and proxy match the lead.
The inventory is up to date,
Then off hops Bunny through the gate.

codescene-delta-analysis[bot]

This comment was marked as outdated.

@mergify

mergify Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

This pull request is merged.

…entory

The `alpine` final-stage digest moved to `f59abe6` in #1191 (proxy) and #1190
(auth), but the inventory still pinned `294b683` for both. Record the new pin
and keep the superseded digest as history, so the next refresh has a baseline.

Refs #1190

Signed-off-by: Elshaday Mengesha <elishum8@gmail.com>
@Rick1330
Rick1330 force-pushed the docs/base-image-inventory-alpine branch from 6def09b to 2d2e91d Compare November 21, 2026 09:28
codescene-delta-analysis[bot]

This comment was marked as outdated.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

devin-ai-integration[bot]

This comment was marked as resolved.

greptile-apps[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

greptile-apps[bot]

This comment was marked as resolved.

Verified against the registry: `f59abe6` is alpine:3.24.4, not 3.24.2, and its
published date is 2026-11-05. The digest entered this tree on 2026-11-21 in
`ba956d4` (proxy) and `ca9248c` (auth), which is the date the file's method
requires. `294b683` is not superseded: `services/relay/Dockerfile` still pins
it, so both digests are active.

Refs #1292

Signed-off-by: Elshaday Mengesha <elishum8@gmail.com>

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No application code in the PR — skipped Code Health checks.

See analysis details in CodeScene

Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@sonarqubecloud

Copy link
Copy Markdown

@Rick1330
Rick1330 merged commit f2a0376 into main Nov 21, 2026
100 checks passed
@Rick1330
Rick1330 deleted the docs/base-image-inventory-alpine branch November 21, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Markdown, MDX, roadmap, ADRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(quality): keep the base-image inventory in step with the alpine digest

1 participant