Repository navigation
Conversation
time.clock() was removed in Python 3.8. timeThis swallowed the AttributeError and returned (None, None), so getStatus saw block 0 and never reported a connection on 3.10 builds. A failed mnsync timing is None, not 0: r_time1 + None raised inside the watchdog slot and PyQt aborted. Guard the None and keep the ping display.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #28, keeping the ping display instead of removing it.
time.clock()was removed in Python 3.8.timeThisswallowed the AttributeError and returned(None, None), sogetStatussaw block 0 and every 3.10 build reported the RPC server as unreachable.With the clock fixed, a failed
mnsynctiming isNone, andr_time2 != 0let it through:r_time1 + Noneraised inside theRpcWatchdogslot and PyQt aborted the process. Likely the crash reported on #28.is not Nonethere, plus a None guard on the colour thresholds, same as PIVX-SPMT#80.5 lines, 2 files. Lint clean with CI's pins. Conflicts with #20 only on #20's comment above the same
perf_counterlines.