Repository navigation
Conversation
0.781 rejects builtin generics (tuple[...]), which PIVX-Project#22 uses, and needs typed-ast, which no longer builds on 3.10. 0.920 no longer bundles stubs, so pin them exactly: open ranges pull stubs with positional-only syntax that 0.920 cannot parse. Master and PIVX-Project#20 pass as-is.
Member
Author
|
Update on scope: #22 no longer needs this. a731ef2 moved its annotations to Still worth merging on its own: 0.781 depends on typed-ast, which fails to compile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mypy 0.781 needs typed-ast, which no longer builds on Python 3.10, and it rejects builtin generics (
tuple[...]) that #22 introduces.0.920 no longer bundles typeshed stubs, so
types-requestsandtypes-simplejsonare pinned exactly. Open ranges resolve today to stubs using positional-only parameter syntax, which 0.920 cannot parse (simplejson-stubs/encoder.pyi:60).Checked locally on Python 3.10 with flake8 3.8.4: master, #20 and #22 all pass. Land before #22.