Repository navigation
fix(resolver): use pkgbase for consistent indexing & optimize build force flag #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -58,7 +58,9 @@ async fn collect_all_packages( | |||||||||
|
|
||||||||||
| // Parse .SRCINFO for dependencies | ||||||||||
| if let Ok(metadata) = crate::parser::parse_srcinfo(&cache_path) { | ||||||||||
| aur_packages.insert(pkg.clone(), metadata.clone()); | ||||||||||
| // Store by pkgbase to ensure consistent lookup in Phase 3 | ||||||||||
| aur_packages.insert(metadata.pkgbase.clone(), metadata.clone()); | ||||||||||
|
Comment on lines
60
to
+62
|
||||||||||
| // Store by pkgbase to ensure consistent lookup in Phase 3 | |
| aur_packages.insert(metadata.pkgbase.clone(), metadata.clone()); | |
| // Store by pkgname to remain consistent with downstream resolution logic | |
| aur_packages.insert(pkg.clone(), metadata.clone()); |
Copilot
AI
Mar 21, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There’s trailing whitespace on the blank line after inserting into aur_packages (and it looks like an extra blank line was introduced). This will cause cargo fmt --check to fail if rustfmt hasn’t been run. Please run rustfmt or remove the trailing spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-fis added only whenconfig.clean_buildis true, but Step 4 already doesgit clean -fdx, so-fis least useful in the clean-build case. The non-clean-build path is where existing package archives are most likely to remain and require either-for explicit deletion/reuse logic to avoidmakepkgrefusing to overwrite. Consider inverting the condition or making force/reuse behavior explicit.