Repository navigation
Release 0.2.0 - #191
Merged
Merged
Release 0.2.0#191
Conversation
When PhysioNet cannot be reached and a file or its checksum list is not cached yet, raise one ConnectionError that names the dataset and cache folder, instead of a long proxy or socket traceback. README: note that offline use needs one online load first, describe the source option, XDG_CACHE_HOME and per-server folders, list the errors load() and fetch() raise, and add them to Error Handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
physionet.load()andphysionet.fetch()(Load tables from PhysioNet through a local cache #190) and duplicate-file warnings in validation (Warn about duplicate files during validation #189), with ignore patterns applied the same way in every check.load()andfetch()now raise a singleConnectionErrornaming the dataset and cache folder, instead of a long proxy or socket traceback.sourceoption,XDG_CACHE_HOMEand per-server cache folders are described; the errorsload()andfetch()raise are listed and added to Error Handling.Verification
pytest -q: 312 passed, 1 skipped.