Repository navigation
Type livecheck options instead of **options - #24543
Merged
Merged
Conversation
- `Livecheck.run_checks` was called with a splatted `.compact` hash, which has no shape, so Sorbet checked none of its nine keywords and a mistyped one would only fail at runtime. - `.compact` was a no-op: every value is a non-nil `T::Boolean` and `run_checks` defaults each keyword to `false`.
Contributor
dduugg
enabled auto-merge
November 8, 2026 22:29
bevanjkay
approved these changes
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Livecheck.run_checkssobrew typecheckcatches a mistyped keyword. Splatting a.compacthash left all nine unchecked..compact, a no-op since every value is a non-nil Boolean andrun_checksdefaults each keyword tofalse.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude Code with Opus 5.5, with local review and testing.