Skip to content

Initialize undefined slab angles to NaN - #947

Open
lhy11009 wants to merge 1 commit into
GeodynamicWorldBuilder:mainfrom
lhy11009:along_surface_cleanup
Open

lhy11009 wants to merge 1 commit into
GeodynamicWorldBuilder:mainfrom
lhy11009:along_surface_cleanup

Conversation

@lhy11009

Copy link
Copy Markdown
Contributor

Related to #903 , clean up.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 35163446741

Coverage remained the same at 98.314%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 3 of 3 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 12040
Covered Lines: 11837
Line Coverage: 98.31%
Coverage Strength: 815172.98 hits per line

💛 - Coveralls

@github-actions

Copy link
Copy Markdown
Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.279 ± 0.157 (s=316) 1.280 ± 0.128 (s=390) -2.8% .. +2.9%
Slab interpolation curved simple none 0.770 ± 0.032 (s=613) 0.769 ± 0.032 (s=559) -1.0% .. +0.6%
Spherical slab interpolation simple none 1.283 ± 0.008 (s=335) 1.283 ± 0.007 (s=369) -0.1% .. +0.2%
Slab interpolation simple curved CMS 1.232 ± 0.013 (s=393) 1.232 ± 0.011 (s=340) -0.2% .. +0.2%
Spherical slab interpolation simple CMS 1.634 ± 0.011 (s=272) 1.636 ± 0.011 (s=281) -0.1% .. +0.3%
Spherical fault interpolation simple none 0.897 ± 0.055 (s=508) 0.899 ± 0.054 (s=497) -1.1% .. +1.4%
Cartesian min max surface 2.233 ± 0.081 (s=204) 2.223 ± 0.074 (s=202) -1.6% .. +0.7%
Spherical min max surface 8.610 ± 0.099 (s=53) 8.656 ± 0.109 (s=54) -0.3% .. +1.3%

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants