Repository navigation
Conversation
Owner
|
Thanks. I'll review in the next couple of weeks. |
EvanHahn
pushed a commit
that referenced
this pull request
Nov 3, 2026
`humanizeDuration(1250, { decimal: '$$' })` becomes `1$25 seconds`
because of a quirk of [String.prototype.replace]. This fixes that.
See [#241].
[#241]: #241
[String.prototype.replace]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace
Owner
|
I made a couple of manual tweaks and merged this manually in 06b60ce. Thanks for your contribution, it'll be released soon! |
EvanHahn
pushed a commit
that referenced
this pull request
Nov 3, 2026
`humanizeDuration(1250, { decimal: '$$' })` becomes `1$25 seconds`
because of a quirk of [String.prototype.replace]. This fixes that.
See [#241].
[#241]: #241
[String.prototype.replace]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom decimal separators currently use replacement-string syntax:
humanizeDuration(1250, { decimal: '$$' })produces1$25 seconds, and$&becomes a period. Return the separator from a replacement callback so it stays literal, matching the behavior with digit replacements.Cover replacement tokens in the
decimaloption and a custom language's decimal separator. Update the history and contributor credits as requested by CONTRIBUTING.md.Validation:
npm testpasses on Node 26 and 24, including formatting, lint, type checking, and all 35 tests.