Repository navigation
[ASIM-6693] Add friction factor tuning factors to pipes and wells - #579
Open
eniohayashi wants to merge 1 commit into
Open
eniohayashi wants to merge 1 commit into
eniohayashi wants to merge 1 commit into
Conversation
eniohayashi
force-pushed
the
fb-ASIM-6693-ff-tuning
branch
from
November 5, 2026 20:05
d3fd6e2 to
7d202bd
Compare
eniohayashi
marked this pull request as ready for review
November 5, 2026 20:19
Model calibration against pressure sensor data needs a way to scale the wall and interfacial friction factors of each pipe or well, applied by the application to its friction closures. Add two dimensionless multipliers, defaulting to 1.0, to the pipe and well descriptions, and teach the alfacase loader to read them. Both accept expressions, so parametric runs can drive calibration sweeps. Plain values must be dimensionless and positive; expressions are left for the application to validate once evaluated.
eniohayashi
force-pushed
the
fb-ASIM-6693-ff-tuning
branch
from
November 5, 2026 20:22
7d202bd to
79919e7
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASIM-6693
Adds
wall_friction_tuning_factorandinterfacial_friction_tuning_factorto pipes and wells, so friction factors can be calibrated against pressure measurements. They are dimensionless, default to 1.0 (no change) and may be parametric expressions. Plain values must be positive; expressions are validated by the application once evaluated.Related PR on alfasim: ESSS/alfasim#1558.