Repository navigation
[ASIM-6798] Addition of porosity and por fluid material - #560
Merged
ArleyAllesCruz merged 2 commits intoOct 9, 2026
Merged
ArleyAllesCruz merged 2 commits into
ArleyAllesCruz merged 2 commits into
Conversation
BeneBr
requested changes
Aug 5, 2026
ArleyAllesCruz
force-pushed
the
fb-ASIM-6798-Modify-formation-properties-using-porosity
branch
2 times, most recently
from
August 5, 2026 18:24
b508bfe to
02b0ae9
Compare
|
❌ The last analysis has failed. |
BeneBr
approved these changes
Aug 10, 2026
Contributor
|
I believe that you need to rebase with master to update the pip |
nicoddemus
approved these changes
Aug 10, 2026
ArleyAllesCruz
force-pushed
the
fb-ASIM-6798-Modify-formation-properties-using-porosity
branch
2 times, most recently
from
October 7, 2026 16:29
edb21f9 to
5979111
Compare
BeneBr
approved these changes
Oct 7, 2026
ArleyAllesCruz
force-pushed
the
fb-ASIM-6798-Modify-formation-properties-using-porosity
branch
from
October 9, 2026 08:32
92bdb51 to
41bbe9c
Compare
for more information, see https://pre-commit.ci
|
ArleyAllesCruz
deleted the
fb-ASIM-6798-Modify-formation-properties-using-porosity
branch
October 9, 2026 11:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Motivation
Improve the formation rock thermal properties by accounting for porosity. This PR adds the
attributes needed to describe a porous formation material in
.alfacasefiles; the porositymodel itself is implemented on the ALFAsim side (see the companion PR in
alfasim).How it works
The porosity of a formation material follows Athy's law:
φ₀:initial_porosity, the porosity at the surface [-]b:compaction_coefficient[1/m]z: TVD measured from the formation.ALFAsim uses the porosity of each formation layer to mix the properties of the rock with the
properties of the fluid that fills its pores (
pore_fluid_material), producing the effectivedensity, heat capacity and thermal conductivity of the layer.
Modifications
MaterialDescription: three new optional attributes:initial_porosity:Scalar, categorydimensionless, default0.0 [-].compaction_coefficient:Scalar, categoryper length, default0.0 [1/m].pore_fluid_material:str | None, defaultNone. It is the name of a fluid material(
MaterialType.Fluid) of the case, either a default ALFAsim material (e.g.Brine) or auser-defined one. As with other material references in the SDK (
material,stagnant_fluid),the name is resolved by ALFAsim when the case is loaded, not by the SDK. When
None, ALFAsimuses the default
Brine.MaterialType: newFormation = "formation"member. It represents a porous rock used information layers and is the only type for which the three attributes above are used.
Units / docs
per lengthcategory toCATEGORIES_USED_ON_DESCRIPTIONso its unit list isgenerated and included in the
MaterialDescriptiondocs (together withdimensionless).Generated files
schema.py: new attributes and'formation'in thematerial_typeenum.MaterialDescription.txtandlist_of_unit_for_per_length.txt.tests/alfacase/.Tests
filled_case_descriptions.MATERIAL_DESCRIPTIONnow sets the new attributes to non-defaultvalues (
initial_porosity=0.3,compaction_coefficient=0.0005 1/m,pore_fluid_material="Brine"),so the alfacase round-trip tests actually cover them. Since this fixture is shared with
alfasim, tests there that use it needBrinein their material list (done in thecompanion PR).
test_material_description_as_dictupdated with the new attributes.Related Issue(s)
ASIM-6913 (originally ASIM-6798, which was closed by accident).