Repository navigation
Conversation
No functional change.
… for both cgame and sgame) Do not display the available NaCl targets twice in the BUILD_GAME_NACL_TARGETS cmake help message. No functionnal change.
…set it properly elsewhere Deduplicate the internal cmake list content. No functionnal change.
illwieckz
changed the title
ddf6702 to
e89542d
Compare
Thanks. Of course that's what I meant to do originally, but then I blindly copied the other deps package's formulation. |
e89542d to
bee4653
Compare
illwieckz
changed the title
That was a very good start, myself didn't mind at this point as well.
Great, I rebased this branch without it. |
slipher
left a comment
slipher
left a comment
There was a problem hiding this comment.
LGTM with an optional comment
| list(APPEND NACL_TARGETS "${detected_target}") | ||
| endif() | ||
| endforeach() | ||
| if (NOT "${nacl_target}" IN_LIST NACL_TARGETS) |
There was a problem hiding this comment.
Just add everything to NACL_TARGETS and then use list(REMOVE_DUPLICATES NACL_TARGETS).
bee4653 to
bbebd1c
Compare
cmake: only detect NaCl architectures on -DBUILD_GAME_NACL_TARGETS=nativeFixes #2031:
cmake: explain why the PNaCl SDK is not usable when cross-compilingNo functional change.
cmake: do not append NaCl targets twice (once for all instead of once for both cgame and sgame)Do not display the available NaCl targets twice in the
BUILD_GAME_NACL_TARGETScmake help message.No functionnal change.
cmake: unset the nacl target list before each game iteration, also unset it properly elsewhereDeduplicate the internal cmake list content.
No functionnal change.
Removed:
cmake: download the Saigo SDK for the host, not for the targetMake possible to cross-compile a Windows engine from Linux while running a native Linux SDK to build the NaCl game.
Improve over: