Repository navigation
Only write the shaders.cpp file when its content changes - #1824
Merged
Merged
Conversation
illwieckz
added
T-Improvement
illwieckz
changed the title
shaders.cpp file only if it changedshaders.cpp file when its content changes
slipher
reviewed
Sep 27, 2025
illwieckz
force-pushed
the
illwieckz/conditional-shaders
branch
from
September 27, 2025 21:06
4accb4a to
8d1e485
Compare
slipher
reviewed
Sep 27, 2025
illwieckz
force-pushed
the
illwieckz/conditional-shaders
branch
from
September 27, 2025 21:29
8d1e485 to
0783fa8
Compare
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a reusable helper to write a generated file only if its content changed.
Use it for writing (or not writing) the
shaders.cppfile.Fixes #1820:
shaders.cppfile is always regenerated, forcing to relink the engine client binary #1820