Repository navigation
Handled missing DOM extension during XML import #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <?php | ||
| /** | ||
| * WXR parser selection tests. | ||
| * | ||
| * @package templates-patterns-collection | ||
| */ | ||
|
|
||
| use TIOB\Importers\WP\WXR_Parser; | ||
| use TIOB\Importers\WP\WXR_Parser_SimpleXML; | ||
| use TIOB\Importers\WP\WXR_Parser_XML; | ||
|
|
||
| /** | ||
| * WXR parser on a host without the DOM extension. | ||
| */ | ||
| class WXR_Parser_Without_Dom extends WXR_Parser { | ||
| protected function can_use_simplexml(): bool { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Class WXR_Parser_Test | ||
| */ | ||
| class WXR_Parser_Test extends WP_UnitTestCase { | ||
| /** | ||
| * @var string | ||
| */ | ||
| private $file; | ||
|
|
||
| public function setUp(): void { | ||
| parent::setUp(); | ||
| $this->file = __DIR__ . '/fixtures/export.xml'; | ||
| } | ||
|
|
||
| public function test_parse_uses_simplexml_parser_when_dom_is_available(): void { | ||
| $expected = ( new WXR_Parser_SimpleXML() )->parse( $this->file ); | ||
|
|
||
| $this->assertSame( $expected, ( new WXR_Parser( 'gutenberg' ) )->parse( $this->file ) ); | ||
| } | ||
|
pirate-bot marked this conversation as resolved.
Resolved
|
||
|
|
||
| public function test_parse_falls_back_to_xml_parser_when_dom_is_unavailable(): void { | ||
| $expected = ( new WXR_Parser_XML() )->parse( $this->file ); | ||
|
|
||
| $this->assertSame( $expected, ( new WXR_Parser_Without_Dom( 'gutenberg' ) )->parse( $this->file ) ); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.