Repository navigation
Resolve .local hostnames via mDNS fallback - #64
Open
omelia-iliffe wants to merge 1 commit into
Open
omelia-iliffe wants to merge 1 commit into
omelia-iliffe wants to merge 1 commit into
Conversation
Falls back to an mDNS PTR query when the system reverse lookup finds no name for an IPv4 host on a local subnet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds mDNS reverse lookup for local IPv4 devices when the system reverse lookup returns no hostname.
Without it, devices that only advertise a
.localhostname appear unnamed in Discovery and Ports, particularly on Linux with the minimalnss-mdnsconfiguration.If the system reverse lookup returns nothing, fall back to an mDNS PTR query for IPv4 addresses on a local interface's subnet, with a 1.5 s timeout. The multicast query goes out on the interface whose subnet contains the target, not whichever interface holds the multicast route. Without that, Wi-Fi devices were missed on a machine with both wired and Wi-Fi connections.
resolve_hostnameinsrc/mdns.rsis used by both Discovery and Ports. Addssocket2 = "0.5"as a direct dependency (already in the tree through tokio).IPv6 and off-subnet addresses continue to use the system reverse lookup only.