Skip to content

Iss 121 port external tool from sb graph partitioner - #147

Merged
francosansone merged 72 commits into
sb-graph-devfrom
iss-121-port-external-tool-from-sb-graph-partitioner
Nov 3, 2026
Merged

francosansone merged 72 commits into
sb-graph-devfrom
iss-121-port-external-tool-from-sb-graph-partitioner

Conversation

@francosansone

@francosansone francosansone commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator
  • Added external tools to SBG partitioner.
  • Re-enable partitioner test suite.
  • Added a benchmark for SBG Partitioner, it runs on every new commit to sb-graph-dev and triggers a warning if the time increases 20%.

PD: Many files outside the partitioner directory were modified by the clang-format commit hook.

@Kalashnikovni Kalashnikovni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some remaining big .part files in test/partitioner/sim_models. Are these necessary?

AbsTolerance = {1e-3}
)
);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this empty lines.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe keep the smallest test possible here

)
);


Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment in all the models and part files.

@francosansone

Copy link
Copy Markdown
Collaborator Author

I've just removed all .part and .partition files, also removed the empty lines in the .mo ones.
Just to clarify, the idea of keeping the .partition files was to build a ground truth out of them and ways to compare our algorithm with the state of the art without executing them since they take too long. I'll look for a more appropriate way to store them.

@francosansone
francosansone merged commit 1f755f5 into sb-graph-dev Nov 3, 2026
8 checks passed
@francosansone
francosansone deleted the iss-121-port-external-tool-from-sb-graph-partitioner branch November 3, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

3 participants