Repository navigation
Iss 121 port external tool from sb graph partitioner - #147
Merged
francosansone merged 72 commits intoNov 3, 2026
Merged
francosansone merged 72 commits into
francosansone merged 72 commits into
Conversation
…external-tool-from-sb-graph-partitioner
joaquinffernandez
approved these changes
Nov 2, 2026
Kalashnikovni
left a comment
Collaborator
There was a problem hiding this comment.
There are some remaining big .part files in test/partitioner/sim_models. Are these necessary?
| AbsTolerance = {1e-3} | ||
| ) | ||
| ); | ||
|
|
Collaborator
There was a problem hiding this comment.
We should remove this empty lines.
Collaborator
There was a problem hiding this comment.
Maybe keep the smallest test possible here
| ) | ||
| ); | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
Same comment in all the models and part files.
Collaborator
Author
|
I've just removed all .part and .partition files, also removed the empty lines in the .mo ones. |
Kalashnikovni
approved these changes
Nov 3, 2026
francosansone
deleted the
iss-121-port-external-tool-from-sb-graph-partitioner
branch
November 3, 2026 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PD: Many files outside the partitioner directory were modified by the clang-format commit hook.