Repository navigation
feat!: derive EqHash for properties so floats need no wrapper type - #1098
Merged
Merged
Conversation
k88hudson-cfa
force-pushed
the
k88-property-key
branch
from
November 10, 2026 18:12
ff90abc to
11947f5
Compare
k88hudson-cfa
force-pushed
the
k88-property-key
branch
from
November 10, 2026 19:55
11947f5 to
b15c54d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
define_property!(struct Weight(f64), Person)is allowed and can be indexed, with noOrderedFloatwrapper and noimpl_eq_hashoption.The macros derive a new
#[derive(ixa::EqHash)]instead ofPartialEq, Eq, Hash. It implements the three traits: floats by value), with everything else throughEq + Hash. Float hashing and indexed float queries are about 2x faster.This removes the
impl_eq_hashoption,impl_property_eq!/impl_property_hash!/impl_property_eq_hash!, and the rkyv dependency. I added migration notes for this.