Skip to content

feat!: derive EqHash for properties so floats need no wrapper type - #1098

Merged
k88hudson-cfa merged 3 commits into
mainfrom
k88-property-key
Nov 12, 2026
Merged

k88hudson-cfa merged 3 commits into
mainfrom
k88-property-key

Conversation

@k88hudson-cfa

Copy link
Copy Markdown
Collaborator

define_property!(struct Weight(f64), Person) is allowed and can be indexed, with no OrderedFloat wrapper and no impl_eq_hash option.

The macros derive a new #[derive(ixa::EqHash)] instead of PartialEq, Eq, Hash. It implements the three traits: floats by value), with everything else throughEq + Hash. Float hashing and indexed float queries are about 2x faster.

This removes the impl_eq_hash option, impl_property_eq! / impl_property_hash! / impl_property_eq_hash!, and the rkyv dependency. I added migration notes for this.

@k88hudson-cfa
k88hudson-cfa merged commit c08b16d into main Nov 12, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant