Repository navigation
Conversation
Close gaps found in the final whole-branch review: pin the feed by contract ID or vault() rather than base()/assets() alone, name the decimals-drift residual, name the reviewed commit, correct which views lack a None fallback, drop the wrong governance-on-every-quote claim, fix the contract count in three places, and note the attester can set an earlier expiry than freshness_duration.
verifyFeed now checks the deployed feed's vault() against the vault it was deployed for, so a feed bound to a lookalike vault fails deployment instead of passing because its asset and share token match. withFeed records the feed's own source commit and uncommitted-changes flag separately from the set's, since deploy-feed.ts can add a feed to an older set. Also drops the #[allow(dead_code)] attributes left over in the feed's test fixtures, none of which clippy -D warnings still needs, and extracts the ~40-line kit-vault setup the two kit.rs tests repeated into one helper.
Place every threat under its STRIDE categories and cover the three the existing threats covered least. Repudiation lists which privileged calls publish an event and what proves an act once the RPC drops it. Information disclosure says what is public on chain and what stays off it. Two threats come out of it: a shared signing link shows its call before it lands (R13), and the verifier stub lists and delists without an event (R14). The scope moves to the commit the events were checked against. Closes #438
Present the threat model in the shape the Audit Bank asks for: a data flow diagram with its trust boundaries, numbered flows, issues for each STRIDE category with their remediations, the Soroban checks and the points the repository cannot confirm. Each issue points to the threat that holds its control and tests instead of restating it. Two risks had no threat of their own and get one: a call made in a holder's name (X14) and the choice of which report prices an epoch (O13).
Record what the self-service security tools found in the contracts and how each finding was triaged. Scout is the tool of record: its version, command and raw report are committed, and its 28 hits match an earlier run on the tranche2 tag. Almanax, Certora Sunbeam and a check against the Soroban Security Portal add their findings and proofs. No critical, high or medium finding from the scanners is a new bug. The plan covers the three open bugs the sweep found or confirmed.
feat(feed): expose the share price through SEP-40
feat(examples): read the SEP-40 feed from a consumer
docs: add the STRIDE template and the security scan
docs: map the threat model to STRIDE
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
docs: restore O13 and number the feed threat O14
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.