Skip to content

Tranche 3 - #453

Draft
hpmaxi wants to merge 50 commits into
mainfrom
tranche-3
Draft

hpmaxi wants to merge 50 commits into
mainfrom
tranche-3

Conversation

@hpmaxi

@hpmaxi hpmaxi commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Close gaps found in the final whole-branch review: pin the feed by
contract ID or vault() rather than base()/assets() alone, name the
decimals-drift residual, name the reviewed commit, correct which views
lack a None fallback, drop the wrong governance-on-every-quote claim,
fix the contract count in three places, and note the attester can set
an earlier expiry than freshness_duration.
verifyFeed now checks the deployed feed's vault() against the vault
it was deployed for, so a feed bound to a lookalike vault fails
deployment instead of passing because its asset and share token match.
withFeed records the feed's own source commit and uncommitted-changes
flag separately from the set's, since deploy-feed.ts can add a feed to
an older set.

Also drops the #[allow(dead_code)] attributes left over in the feed's
test fixtures, none of which clippy -D warnings still needs, and
extracts the ~40-line kit-vault setup the two kit.rs tests repeated
into one helper.
hpmaxi and others added 18 commits November 11, 2026 14:44
Place every threat under its STRIDE categories and cover the three the
existing threats covered least. Repudiation lists which privileged calls
publish an event and what proves an act once the RPC drops it.
Information disclosure says what is public on chain and what stays off
it.

Two threats come out of it: a shared signing link shows its call before
it lands (R13), and the verifier stub lists and delists without an event
(R14). The scope moves to the commit the events were checked against.

Closes #438
Present the threat model in the shape the Audit Bank asks for: a data
flow diagram with its trust boundaries, numbered flows, issues for each
STRIDE category with their remediations, the Soroban checks and the
points the repository cannot confirm. Each issue points to the threat
that holds its control and tests instead of restating it.

Two risks had no threat of their own and get one: a call made in a
holder's name (X14) and the choice of which report prices an epoch
(O13).
Record what the self-service security tools found in the contracts and
how each finding was triaged. Scout is the tool of record: its version,
command and raw report are committed, and its 28 hits match an earlier
run on the tranche2 tag. Almanax, Certora Sunbeam and a check against
the Soroban Security Portal add their findings and proofs.

No critical, high or medium finding from the scanners is a new bug. The
plan covers the three open bugs the sweep found or confirmed.
feat(feed): expose the share price through SEP-40
feat(examples): read the SEP-40 feed from a consumer
docs: add the STRIDE template and the security scan
@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
strata-vault-kit-app Ready Ready Preview Nov 13, 2026 4:34pm UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — 268d7523 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant