Repository navigation
[sched] Limit zombie host chain traversal to 10 hops - #7422
Merged
Merged
Conversation
Keep a counter when following merged zombie host links (host.userid == 0) and exit the loop with ERR_DB_NOT_FOUND after 10 iterations so cyclic zombie chains fall back to creating a new host record instead of looping indefinitely. Fixes BOINC#2433 Assisted-by: Antigravity:Gemini-4-Argon
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Member
|
@davidpanderson, please review |
Contributor
|
Good (although the g_reply->hostid line isn't needed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Per @davidpanderson's feedback in #7418, simplify the zombie host chain protection in
authenticate_user()(sched/handle_request.cpp) to a simple loop counter (++n > 10) that exits withERR_DB_NOT_FOUNDand falls back to creating a new host record.Release Notes
N/A
Fixes #2433
Assisted-by: Antigravity:Gemini-4-Argon
Summary by cubic
Prevents infinite loops in
authenticate_user()when following zombie host chain links by capping traversal at 10 hops, and clears the reply host id in the fallback path. Fixes #2433.ERR_DB_NOT_FOUNDafter 10 hops so cyclic chains create a new host record instead of looping forever.g_reply->hostidto 0 when falling back to a new host, matching the existingg_request->hostidreset.Written for commit aeb8def. Summary will update on new commits.