[gdevenyi]

Why

On Fedora, the toolkit installs a NIFTI package (share/cmake/NIFTI) that refers to archives it never installs. Each find_package(NIFTI) against such an install fails:

The imported target "NIFTI::znz" references the file
   ".../lib64/libznz.a"
but this file does not exist.

cmake-modules/BuildNIFTI.cmake stages nifti_clib into ${CMAKE_INSTALL_LIBDIR}, which is lib64 on Fedora. But the superbuild installs only lib${LIB_SUFFIX} from its staging tree (CMakeLists.txt, the INSTALL(DIRECTORY …/lib${LIB_SUFFIX}) rule). So libniftiio.a, libznz.a and libnifti2.a stay in the staging tree.

This defect is already on develop-1.9.18. Nothing loaded the NIFTI package until now, so nobody saw it. BIC-MNI/libminc#156 adds find_dependency(NIFTI) to LIBMINCConfig.cmake, and without this fix, find_package(LIBMINC) fails on each Fedora toolkit install.

What

BuildNIFTI.cmake stages into lib${LIB_SUFFIX}, the directory that the superbuild installs. This is the convention that the rest of the superbuild uses already (LIBMINC_INSTALL_LIB_DIR, CMAKE_INSTALL_RPATH, the staging install rule). The change is to CMAKE_INSTALL_LIBDIR, NIFTI_INSTALL_LIBRARY_DIR, the install RPATH, and the NIFTI_LIBRARY / ZNZ_LIBRARY paths.

Verification

• Local: configured with -DCMAKE_INSTALL_LIBDIR=lib64 (the Fedora value) and built the NIFTI target. The three archives are staged in lib/, and NIFTITargets-release.cmake refers to lib/.
• CI, on a throwaway branch that has the libminc NIfTI PRs (develop-1.9.19 HEAD refers to an Elastix commit that doesn't exist #152, Fixes for 22.04 build #154, Make config ANTSPATH dependent on BUILD_ANTS #155, Time to drop LD_LIBRARY_PATH? #156) merged. Each job installs the toolkit and builds a separate project against the installed LIBMINC::minc2 and LIBMINC::nifti:
  • Without this commit, Fedora fails with the error above: https://github.com/gdevenyi/minc-toolkit-v2/actions/runs/35641425624/job/106471402541
  • With this commit, the consumer passes in all 8 jobs: https://github.com/gdevenyi/minc-toolkit-v2/actions/runs/35648847130/job/106495901882 (Fedora minimal). ctest results are the same as develop-1.9.18: macOS fails only nu_reference_1.

Notes

• Most other Build*.cmake modules already pass -DCMAKE_INSTALL_LIBDIR=lib${LIB_SUFFIX} (FFTW, freeglut, JPEG, netCDF, OpenBLAS). BuildOpenJPEG.cmake uses ${CMAKE_INSTALL_LIBDIR} too, so a vendored OpenJPEG on a lib64 system is also not installed. That has less effect: its archive is static and linked at build time, and its CMake package is in the same lib64/ directory, so nothing installed refers to a missing file. I left it out of this PR.
• Merge this before, or together with, the libminc submodule bump that includes Export LIBMINC::nifti, and install the bundled NIfTI with libminc libminc#156.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RCrjXCD1KiTWLtah7wmySX

[gdevenyi]

This is currently fixing the cmake to be consistent but there's an alternative PR that makes the superbuild use CMAKE_INSTALL_LIBDIR everywhere instead, which would make it closer to standard cmake.