Repository navigation
Fix subtype parsing for strain names with spaces - #31
Merged
Merged
Conversation
A reference header with no (HxNy) now fails instead of naming VCFs unknown, because fluscan-db parses that token. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Restores everything else in this PR to main, including the unknown fallback. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jpalmer37
marked this pull request as ready for review
November 6, 2026 18:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subtype regex in
modules/nextclade/nextclade.nfcouldn't read a strain name with a space, so a header likeA/Fancy chicken/NL/FAV-0033-1-2021/2021(H5N1)named every VCF__unknown__. The strain part of the regex now accepts anything except parentheses. Theunknownfallback is unchanged.Tested with a local Nextflow run on 5 H5N1 samples against the PV312101.1-PV312108.1
chicken2021bundle and 1 H1N1 sample againstwisconsin588: all 44 Nextclade VCFs are named__PV3121xx.1__H5N1__or__MW6260xx.1__H1N1__, andCHROMmatches the name. The sed expression also resolves the subtype for all 120reference.fastafiles under the local references folder.tests/was not run, because no test reads this line.