Repository navigation
Accept a per-sample DB bundle in the FASTA sample sheet - #27
Merged
Merged
Conversation
25-7015--WLH25-1607 cleaned to -WLH25-1607; it now cleans to WLH25-1607. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An optional DB column gives each FASTA sample its own bundle, so one run can mix subtypes. Run-level Nextclade and reference_remap outputs move under a <db>/ directory, and aggregate/sample_ids.csv records each input ID's cleaned sample_id and bundle. Manifest version 1.1.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A FASTA sample sheet can carry a
DBcolumn so one run mixes subtypes, each sample analysed against its own bundle. A blank cell, or no column, falls back to--db. auto-fluscan fills the column from the nf-flu run summary's subtype call.Where to look:
modules/shared/sample_id.nfanddatabase.nf:fasta_sample_channel,input_db_paths,resolve_dbs. Every bundle is validated at startup, and names must be unique.workflows/paftools.nfandworkflows/nextclade.nf: BLAST db, SnpEff dir, Nextclade batches, coordinate map, FluMut merge and provenance are now keyed by bundle.makeblastdb,blastnandpipeline_provenancechanged signature, soworkflows/short-read.nfchanged with them. Short-read stays single-bundle and rejects aDBcolumn.Breaking for any run, single-bundle included: run-level paths move to
nextclade/<db>/<SEG>_output,nextclade/status/<db>/andaggregate/reference_remap/<db>/. Per-sample paths and VCF names are unchanged, and fluscan-db reads none of the moved paths. New:aggregate/sample_ids.csv(input_id,sample_id,db). The manifest version is 1.1.0.A separate commit fixes
clean_sample_idso25-7015--WLH25-1607cleans toWLH25-1607instead of-WLH25-1607.Testing, run locally on macOS with a GNU shim: a mixed sheet (2 H5N1 on gsgd, 1 H1N1 on wisconsin588) against each subtype run alone with
--db. Per-sample VCFs, QC, FluMut, watchlist outputs and coordinate maps were identical; only Nextclade'screatedAtand GFF batch order differed.--fasta_inputwith--dbis unchanged. Short-read was only checked through BLAST: onmainit already fails atmake_pileup.py, which #15 deleted butmodules/short_read/alignment.nfstill calls.🤖 Generated with Claude Code