Repository navigation
Core - Fix profile service, storage and device bugs found by the tests - #912
Merged
Merged
Conversation
…by the auto-arrange fallback - Headsets with 2 or 4 LEDs get their default layout, the files are named "... LEDs headset.xml" - Devices placed by the auto-arrange fallback get the z-index of their type
…red setting can't be read
- New profiles are stored at the current migration version, so they're no longer migrated on every start and can be duplicated right away - A category created at the top is listed first right away, so its profiles render on top - CloneProfileConfiguration makes a copy of the stored data, saving a clone stores its profile through the original - Importing a profile raises ProfileAdded - A profile configuration that isn't valid JSON is logged and skipped instead of stopping all migrations - A stored profile without a version is migrated from version 0, like an imported one - ProfileCategoryRepository.IsUnique returns true when the name is free - M0001 and M0004 leave a missing node type or storage out instead of writing null - M0003 also unwraps a list that is an item of another list
RobertBeekman
marked this pull request as ready for review
October 24, 2026 14:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the profile service, storage and device bugs found by the test suite (#907). Each fix flips the test that pinned the old behaviour.
Fixed
CreateProfileConfigurationnow also saves the profile, which sets the version.Artemis 2 LED headset.xml, but the files are named... LEDs headset.xml.CloneProfileConfigurationmakes a real copy. The clone used the same stored data as the original. Saving a clone withSaveProfilenow stores its profile through the original. The workshop submission wizard relies on this.GetSetting, instead ofdefault(T).ProfileAdded.ProfileCategoryRepository.IsUniquereturns true when the name is free. Nothing calls it yet.null.Not changed
ActivationBehaviouron profile configurations is stored, but nothing in Core reads it. That needs a decision on what it should do, so it's left out.Testing
Artemis.Core.Tests: 1385 passedArtemis.UI.Shared.Tests: 176 passed