From 56445a31d137f70360bd2ba05f2a49eab308694c Mon Sep 17 00:00:00 2001 From: orzel320 <52106515+orzel320@users.noreply.github.com> Date: Mon, 19 Oct 2026 10:59:15 +0200 Subject: [PATCH 1/5] readded windows readme_cpp check in actions --- .github/workflows/buildwheels.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/buildwheels.yml b/.github/workflows/buildwheels.yml index 0fd530a8..78bf0c28 100644 --- a/.github/workflows/buildwheels.yml +++ b/.github/workflows/buildwheels.yml @@ -347,7 +347,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, ubuntu-24.04-arm, macos-15, macos-15-intel] # TODO #558 windows-latest] + os: [ubuntu-latest, ubuntu-24.04-arm, macos-15, macos-15-intel, windows-latest] steps: - uses: actions/checkout@v7 with: @@ -365,7 +365,7 @@ jobs: uses: msys2/setup-msys2@v2 with: msystem: UCRT64 - update: false + update: true install: >- mingw-w64-ucrt-x86_64-gcc mingw-w64-ucrt-x86_64-ninja From 6b9986e9f188f922baf68db6c9d721323a8412c6 Mon Sep 17 00:00:00 2001 From: orzel320 <52106515+orzel320@users.noreply.github.com> Date: Fri, 23 Oct 2026 02:52:06 +0200 Subject: [PATCH 2/5] Attempted updating msys2 version for building wheels --- .github/workflows/buildwheels.yml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/buildwheels.yml b/.github/workflows/buildwheels.yml index 78bf0c28..f52038c4 100644 --- a/.github/workflows/buildwheels.yml +++ b/.github/workflows/buildwheels.yml @@ -53,13 +53,18 @@ jobs: - if: matrix.os == 'windows-latest' uses: msys2/setup-msys2@v2 with: - msystem: MINGW64 + msystem: UCRT64 update: false install: >- - mingw-w64-x86_64-gcc-fortran - mingw-w64-x86_64-ninja + mingw-w64-ucrt-x86_64-gcc-fortran + mingw-w64-ucrt-x86_64-ninja m4 - + - if: matrix.os == 'windows-latest' + shell: msys2 {0} + run: | + echo "$(cygpath -m /ucrt64/bin)" >> $GITHUB_PATH + echo "$(cygpath -m /usr/bin)" >> $GITHUB_PATH + - uses: actions/setup-python@v6 with: python-version: "3.11" @@ -72,7 +77,7 @@ jobs: # skip 32-bit, musllinux, and free-threaded builds CIBW_SKIP: "*-win32 *-manylinux_i686 *musllinux* cp3??t-* cp314-macosx_x86_64 cp315-macosx_x86_64" CIBW_BEFORE_BUILD_WINDOWS: pip install delvewheel - CIBW_ENVIRONMENT_WINDOWS: CMAKE_ARGS="-DCMAKE_MAKE_PROGRAM=D:/a/_temp/msys64/mingw64/bin/ninja.exe" CMAKE_PROGRAM_PATH="D:/a/_temp/msys64/usr/bin" CMAKE_GENERATOR="Ninja" TEMP="D:/a/_temp/" + CIBW_ENVIRONMENT_WINDOWS: CMAKE_ARGS="-DCMAKE_MAKE_PROGRAM=D:/a/_temp/msys64/ucrt64/bin/ninja.exe" CMAKE_PROGRAM_PATH="D:/a/_temp/msys64/usr/bin" CMAKE_GENERATOR="Ninja" TEMP="D:/a/_temp/" CIBW_REPAIR_WHEEL_COMMAND_WINDOWS: delvewheel repair -w {dest_dir} {wheel} CIBW_BEFORE_BUILD_MACOS: brew reinstall gcc; pip install --only-binary=llvmlite llvmlite CIBW_ENVIRONMENT_MACOS: MACOSX_DEPLOYMENT_TARGET=`sw_vers -productVersion` SYSTEM_VERSION_COMPAT=0 From 5751cd3630b44093b2ed269280ad6ea213849b27 Mon Sep 17 00:00:00 2001 From: orzel320 <52106515+orzel320@users.noreply.github.com> Date: Sat, 24 Oct 2026 15:03:34 +0200 Subject: [PATCH 3/5] Checking if adding an upper constraint to nanobind version on windows fixes the error. --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 8d2989d7..a6194631 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -252,7 +252,7 @@ exclude = [ ] [build-system] -requires = ["scikit-build-core >=0.4.3", "nanobind >=1.3.2", "setuptools-scm==8.3.1"] +requires = ["scikit-build-core >=0.4.3", "nanobind >=1.3.2,<3.0.1; sys_platform == 'win32'", "nanobind >=1.3.2; sys_platform != 'win32'" "setuptools-scm==8.3.1"] build-backend = "scikit_build_core.build" [project] From 1b2b03497f6318c2a462304b07abbfe4c5fcff1c Mon Sep 17 00:00:00 2001 From: orzel320 <52106515+orzel320@users.noreply.github.com> Date: Sat, 24 Oct 2026 15:09:54 +0200 Subject: [PATCH 4/5] added a missing comma in pyproject.toml --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index a6194631..f61223f5 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -252,7 +252,7 @@ exclude = [ ] [build-system] -requires = ["scikit-build-core >=0.4.3", "nanobind >=1.3.2,<3.0.1; sys_platform == 'win32'", "nanobind >=1.3.2; sys_platform != 'win32'" "setuptools-scm==8.3.1"] +requires = ["scikit-build-core >=0.4.3", "nanobind >=1.3.2,<3.0.1; sys_platform == 'win32'", "nanobind >=1.3.2; sys_platform != 'win32'", "setuptools-scm==8.3.1"] build-backend = "scikit_build_core.build" [project] From d556843add468652bc13e7acdf407d0d535c23d4 Mon Sep 17 00:00:00 2001 From: orzel320 <52106515+orzel320@users.noreply.github.com> Date: Sat, 24 Oct 2026 17:30:09 +0200 Subject: [PATCH 5/5] attempt to run windows actions with nanobind 2.15.0 --- pyproject.toml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index f61223f5..f8e68630 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -267,7 +267,8 @@ authors = [ license = "GPL-3.0" dependencies = [ "numpy", - "nanobind" + "nanobind >=1.3.2,<3.0.1; sys_platform == 'win32'", + "nanobind >=1.3.2; sys_platform != 'win32'", ] [project.optional-dependencies]