From 803bbae63a58d3ac8546cdddf3d91bf75a6693fd Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed, 28 Oct 2026 16:29:18 +0000 Subject: [PATCH 1/4] refactor(testcerts): correct stale key generation error messages - Maintainability Hunter Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- testcerts.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/testcerts.go b/testcerts.go index acf0d00..10542e9 100644 --- a/testcerts.go +++ b/testcerts.go @@ -418,7 +418,7 @@ func genSelfSignedKeyPair(cert *x509.Certificate) (*pem.Block, *ecdsa.PrivateKey // Create a Private Key key, err := ecdsa.GenerateKey(elliptic.P521(), rand.Reader) if err != nil { - return nil, nil, fmt.Errorf("could not generate rsa key - %w", err) + return nil, nil, fmt.Errorf("could not generate ecdsa key - %w", err) } // Use CA Cert to sign and create a Public Cert @@ -438,12 +438,12 @@ func genKeyPair( // Create a Private Key key, err := ecdsa.GenerateKey(elliptic.P521(), rand.Reader) if err != nil { - return nil, nil, fmt.Errorf("could not generate rsa key - %w", err) + return nil, nil, fmt.Errorf("could not generate ecdsa key - %w", err) } signedCert, err := x509.CreateCertificate(rand.Reader, cert, ca, &key.PublicKey, caKey) if err != nil { - return nil, nil, fmt.Errorf("could not generate self-signed certificate - %w", err) + return nil, nil, fmt.Errorf("could not generate certificate - %w", err) } return certToPemBlock(signedCert), key, nil } From ef83347ebc7a88ace77ea7bfae4865508e285330 Mon Sep 17 00:00:00 2001 From: Benjamin Cane Date: Sun, 1 Nov 2026 15:37:09 -0700 Subject: [PATCH 2/4] Apply suggestion from @madflojo --- testcerts.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testcerts.go b/testcerts.go index 10542e9..d53b69d 100644 --- a/testcerts.go +++ b/testcerts.go @@ -418,7 +418,7 @@ func genSelfSignedKeyPair(cert *x509.Certificate) (*pem.Block, *ecdsa.PrivateKey // Create a Private Key key, err := ecdsa.GenerateKey(elliptic.P521(), rand.Reader) if err != nil { - return nil, nil, fmt.Errorf("could not generate ecdsa key - %w", err) + return nil, nil, fmt.Errorf("could not generate key - %w", err) } // Use CA Cert to sign and create a Public Cert From c33591e87fff1b52f5f303e7b41b1598ef48c9b8 Mon Sep 17 00:00:00 2001 From: Benjamin Cane Date: Sun, 1 Nov 2026 15:37:26 -0700 Subject: [PATCH 3/4] Apply suggestion from @madflojo --- testcerts.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testcerts.go b/testcerts.go index d53b69d..f6cd8dd 100644 --- a/testcerts.go +++ b/testcerts.go @@ -438,7 +438,7 @@ func genKeyPair( // Create a Private Key key, err := ecdsa.GenerateKey(elliptic.P521(), rand.Reader) if err != nil { - return nil, nil, fmt.Errorf("could not generate ecdsa key - %w", err) + return nil, nil, fmt.Errorf("could not generate key - %w", err) } signedCert, err := x509.CreateCertificate(rand.Reader, cert, ca, &key.PublicKey, caKey) From aba3fd564b6b47fece45822cb7f1c26b1537bdb2 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 1 Nov 2026 22:40:22 +0000 Subject: [PATCH 4/4] Pin Go toolchain for golangci-lint Co-authored-by: madflojo <1731256+madflojo@users.noreply.github.com> --- .github/workflows/lint.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index ecab68e..e570f8e 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -13,6 +13,9 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 + - uses: actions/setup-go@v5 + with: + go-version: '1.24.x' - name: golangci-lint uses: golangci/golangci-lint-action@v8 with: