You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Two new first-party packs under packs/. Both show up in "New game".
turn-battle: a 3 on 3 JRPG-style battle. Everyone acts once a round, fastest first; heroes have attacks, arts (bash, fireball, mend), guard and potions; foes can poison and be stunned. Damage is 2d6. It uses only R1–R4 pieces: no engine changes. A strategy bot wins 88% of 500 battles and random play wins 17%.
narrative-check: dorm-302's rules plus clamp(). dorm-302 switched to a vendored copy (luoxin9510/dorm-302 branch narrative-check-pack). Its check-ink --all --novelty --random 300 output is byte-for-byte identical before and after the switch, in both zh and en.
Tests: each template is current and plays to an ending; a 3 on 3 round follows speed order. All 600 tests pass.
Not in this PR: vault tutorials 10.6/10.7 and the Obsidian check (that needs the plugin deployed).
Review of the two new packs (turn-battle, narrative-check). I read packs/turn-battle/rules.ink and system.md closely. I did not run the test suite (the sandbox blocked it), so I can't confirm tests/packs.test.ts and tests/system.test.ts pass. I did not read the narrative-check pack, the other templates, or the test diffs.
No blocking bugs found in turn-battle. The pack adds no src/ code, so the Node/Electron, T(), innerHTML and minAppVersion checks don't apply.
One minor point: rules.ink uses stat(x, "art") == 0 to mean "this is a foe" (battle and hurt). A hero a game adds with art: 0 would be played as a foe, and hurt would treat it as a foe and remove it instead of laying it down at 0 HP. This is fine for the shipped party, but worth a comment in the header or a separate foe flag.
I would merge as is, provided CI is green (it runs the pack tests).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two new first-party packs under
packs/. Both show up in "New game".clamp(). dorm-302 switched to a vendored copy (luoxin9510/dorm-302 branch narrative-check-pack). Itscheck-ink --all --novelty --random 300output is byte-for-byte identical before and after the switch, in both zh and en.🤖 Generated with Claude Code
https://claude.ai/code/session_015vdVgYTb9jm7MRdePSgs8B