Skip to content

pre-commit: fix hooks failing on Windows dev checkouts - #4588

Merged
HiFiPhile merged 2 commits into
masterfrom
windows-precommit-fixes
Nov 21, 2026
Merged

HiFiPhile merged 2 commits into
masterfrom
windows-precommit-fixes

Conversation

@HiFiPhile

Copy link
Copy Markdown
Collaborator

On a Windows dev checkout pre-commit run --all-files failed 7 hooks (gen-doc, host-test, hil-test, change-impact-test, claude-scripts, drivers-coverage, membrowse-targets). With this PR all 17 hooks pass on Windows.

Changes

  • test/hil/helper/agentrc.py: since hil: load agentrc from the installed copy; only CI fetches the pin #4436, any <root>/.agentrc counts as a copy staged by hil_remote.py. A developer who keeps an agentrc clone at that path (and names it with AGENTRC_DIR) hit .agentrc\manifest.json is not readable JSON on every agentrc load. A staged copy is plain files plus a manifest and never a git checkout, so a .agentrc that contains .git is now treated as an installed agentrc. An empty or broken staged copy is still refused. New test: test_an_agentrc_checkout_at_the_stage_path_is_an_install_not_a_stage.
  • host-test hook: sh -c doesn't exist on Windows, so the hook now runs through tools/hook_steps.py like the other multi-step hooks. It also passes -G Ninja, with ninja installed into the hook venv: on Windows CMake's default generator is Visual Studio, whose MSVC the host fixtures refuse. Ninja uses the gcc on PATH (MinGW on Windows, the system gcc on Linux).
  • tools/build.py get_examples: an example must have a CMakeLists.txt. Untracked IDE or build leftovers (IAR Debug/, settings/) were listed as targets, which broke the membrowse-targets mirror test. Every tracked example already has one. The ESP fixture in test_code_size.py gains the top-level CMakeLists.txt that real examples have.
  • .claude/test/test_build.py: test_shared_uses_the_canonical_hil_dir read the developer's real cmake-build/cmake-build-stm32f407disco and failed when a code-size run had configured it with LINKERMAP_OPTION. It now runs in a scratch ROOT, like the test next to it.

Validation

pre-commit run --all-files passes all 17 hooks on Windows 10 (Python 3.12, ucrt64 gcc). There are no firmware changes.

- agentrc: a git checkout at <root>/.agentrc is an installed agentrc, not a hil_remote stage (a stage is plain files plus a manifest); an in-tree agentrc clone broke every agentrc load since #4436
- host-test: run through tools/hook_steps.py (Windows has no sh), with -G Ninja and ninja from the hook venv so CMake takes gcc rather than Visual Studio's MSVC
- build.py get_examples: an example has a CMakeLists.txt; untracked IDE/build leftovers (IAR Debug/, settings/) are not examples
- test_build: test_shared_uses_the_canonical_hil_dir runs in a scratch ROOT instead of the developer's real cmake-build dir
@greptile-apps

greptile-apps Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] The PR appears safe to merge; the separate build directory fixes the previous hook failure.

Summary

Fixes Windows pre-commit failures without changing firmware.

  • The host-test hook runs its CMake steps with Ninja instead of sh.
  • An agentrc checkout at .agentrc is loaded as an install.
  • Example scans list only folders with a top-level CMakeLists.txt.
  • The build-path test uses a scratch root.

The previous build-directory finding is fully fixed. No new issues found.

Reviews (2) · Last reviewed commit: "pre-commit: host-test builds in a Ninja ..." · Reviewed by Greptile

Comment thread .pre-commit-config.yaml Resolved
CMake refuses to reconfigure an existing build/host-test (the README's manual build, Unix Makefiles) under -G Ninja.
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The changes update agentrc source selection, example discovery, and the host-test pre-commit hook. They also adjust the shared-build test setup and the code-size test fixture.

Possibly related PRs

Merge Risk: Minimal · up to 7bfb5

This PR fixes pre-commit hooks that failed on Windows development checkouts. It changes how an installed agentrc is detected, which examples are treated as buildable, and how the host-test hook builds. No concrete regression was found in the reviewed changes, and the changes are limited to developer tooling and tests, so merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the pre-commit hooks that failed on Windows dev checkouts are fixed. The changeset covers the host-test hook, agentrc staging detection, get_examples filtering, and te…
Description check Passed The description states the failing hooks on a Windows checkout and the fix for each. It explains the agentrc, host-test hook, get_examples, and test_build.py changes, and it lists validation results. …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the pre-commit hooks that failed on Windows dev checkouts are fixed. The changeset covers the host-test hook, agentrc staging detection, get_examples filtering, and test fixes, all aimed at the Windows hook failures. The title is specific and concise, and it matches the PR objectives.

Full details: Description check

Explanation

The description states the failing hooks on a Windows checkout and the fix for each. It explains the agentrc, host-test hook, get_examples, and test_build.py changes, and it lists validation results. These match the changes in the raw summary and the PR objectives.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
Simplify code

  • Commit to this branch
  • Create a new PR
Fix failing CI checks

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9c3eb0d9-fe12-4532-8b22-06913fa8336c
Commits

Reviewing files that changed from the base of the PR and between 9f4eb56 and 7bfb582.

Files selected for processing: 6

  • .claude/test/test_build.py
  • .pre-commit-config.yaml
  • test/hil/helper/agentrc.py
  • test/hil/test/test_code_size.py
  • test/hil/test/test_hil_agentrc.py
  • tools/build.py

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@github-actions

Copy link
Copy Markdown

MemBrowse Memory Report · Explore what changed →

No memory changes detected across 1178 targets.


Catch memory regressions in CI with MemBrowse. Free for open source.

@github-actions

Copy link
Copy Markdown

Code size

Baseline: 9f4eb56 (exact) https://github.com/hathach/tinyusb/actions/runs/44813545104

  • 22 baseline elfs are of examples this PR did not build (outside coverage)

1156 builds on 35 boards compared, 0 changed

no changes
Full report

@github-actions

Copy link
Copy Markdown

Hardware-in-the-loop (HIL) Test Report

hfp-iar

✅ 110 passed · ❌ 0 failed · ⚪ 2 skipped · blank not run

Board usbtest cdc_msc_throughput audio_test_freertos cdc_dual_ports cdc_msc cdc_msc_freertos dfu dfu_runtime hid_boot_interface hid_generic_inout midi_test msc_dual_lun mtp net_lwip_webserver previous-cleanup-failure printer_to_cdc usbtmc duration
stm32l412nucleo ✅ 30/30 ✅ C 508/511k M 511/511k ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ last failed cleanup 2026-11-21T12:09:06+0100 (found-left, hil_test.py pid 277493, id 40a54f11e265e20e): the task ended without its cleanup ✅ ✅ 22/22 106s
lpcxpresso43s67 ✅ 30/30 ✅ C 10.8/9.6M M 33.9/30.8M ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 180.9 Mbit/s last failed cleanup 2026-11-21T12:09:06+0100 (found-left, hil_test.py pid 277497, id a48e1e62bb6cc130): the task ended without its cleanup ✅ ✅ 16/22 (6 skipped) 109s
ra4m2_ek ✅ 30/30 ✅ C 845/447k M 926/511k ⚪ ✅ ✅ ⚪ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ last failed cleanup 2026-11-21T12:09:06+0100 (found-left, hil_test.py pid 277496, id 087cb90f8deeec17): the task ended without its cleanup ✅ ✅ 22/22 125s
stm32f746disco ✅ 30/30 ✅ C 13.2/12.4M M 26.2/30.9M ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 156.0 Mbit/s last failed cleanup 2026-11-21T12:09:06+0100 (found-left, hil_test.py pid 277494, id 579c1755efe3b986): the task ended without its cleanup ✅ ✅ 16/22 (6 skipped) 94s
stm32f746disco-DMA ✅ 30/30 ✅ C 13.4/12.2M M 26.5/33.1M ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 186.3 Mbit/s ✅ ✅ 16/22 (6 skipped) 89s
stm32u5a5nucleo ✅ 30/30 ✅ C 13.3/14.2M M 20.2/31M ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 160.3 Mbit/s last failed cleanup 2026-11-21T12:09:06+0100 (found-left, hil_test.py pid 277495, id 3e670432772ab3de): the task ended without its cleanup ✅ ✅ 16/22 (6 skipped) 124s
stm32u5a5nucleo-DMA ✅ 30/30 ✅ C 11/10.5M M 27.7/33.1M ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 186.6 Mbit/s ✅ ✅ 16/22 (6 skipped) 114s

hfp.json

✅ 110 passed · ❌ 0 failed · ⚪ 2 skipped · blank not run

Board usbtest cdc_msc_throughput audio_test_freertos cdc_dual_ports cdc_msc cdc_msc_freertos dfu dfu_runtime hid_boot_interface hid_generic_inout midi_test msc_dual_lun mtp net_lwip_webserver printer_to_cdc usbtmc duration
stm32l412nucleo ✅ 30/30 ✅ C 508/511k M 512/511k ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 22/22 110s
ra4m2_ek ✅ 30/30 ✅ C 804/447k M 968/511k ⚪ ✅ ✅ ⚪ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 22/22 128s
lpcxpresso43s67 ✅ 30/30 ✅ C 12/10.3M M 34.7/31.2M ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 182.1 Mbit/s ✅ ✅ 16/22 (6 skipped) 128s
stm32f746disco ✅ 30/30 ✅ C 13.2/12.2M M 25.3/30.9M ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 156.4 Mbit/s ✅ ✅ 16/22 (6 skipped) 101s
stm32f746disco-DMA ✅ 30/30 ✅ C 13.4/12.2M M 25.6/30.9M ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 185.4 Mbit/s ✅ ✅ 16/22 (6 skipped) 87s
stm32u5a5nucleo ✅ 30/30 ✅ C 13.3/13.6M M 20.2/31.2M ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 165.7 Mbit/s ✅ ✅ 16/22 (6 skipped) 134s
stm32u5a5nucleo-DMA ✅ 30/30 ✅ C 11.8/11.7M M 27.4/32.6M ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 186.3 Mbit/s ✅ ✅ 16/22 (6 skipped) 120s

tinyusb-esp.json

✅ 35 passed · ❌ 1 failed · ⚪ 0 skipped · blank not run

Board usbtest cdc_msc_throughput msc_file_explorer_freertos audio_test_freertos cdc_msc_freertos device_info dfu_runtime hid_composite_freertos mtp duration
espressif_p4_function_ev ✅ 30/30 ✅ C 13.1/9.7M M 20.2/31.5M 409 KB/s ✅ ✅ ✅ ✅ ✅ ✅ 100s
espressif_p4_function_ev-DMA ✅ 30/30 ✅ C 15.6/9.4M M 24.5/31.5M 409 KB/s ✅ ✅ ✅ ✅ ✅ ✅ 104s
espressif_s3_devkitm ✅ 30/30 ✅ C 507/511k M 532/511k 409 KB/s ❌ ✅ ✅ ✅ ✅ ✅ 141s
espressif_s3_devkitm-DMA ✅ 30/30 ✅ C 507/511k M 511/511k 409 KB/s ✅ ✅ ✅ ✅ ✅ ✅ 137s

tinyusb.json

✅ 487 passed · ❌ 6 failed · ⚪ 26 skipped · blank not run

Board usbtest cdc_msc_throughput msc_file_explorer msc_file_explorer_freertos audio_test_freertos cdc_dual_ports cdc_msc cdc_msc_freertos cdc_msc_hid device_info dfu dfu_runtime hid_boot_interface hid_generic_inout host_info_to_device_cdc midi_test msc_dual_lun mtp net_lwip_webserver printer_to_cdc usbtmc duration
raspberry_pi_pico_w 1101 KB/s 1022 KB/s ✅ ✅ 23s
frdm_k64f ⚪ ⚪ ❌ ✅ 27s
raspberry_pi_pico2 1139 KB/s 1022 KB/s ✅ ✅ 43s
ek_tm4c123gxl ✅ 30/30 ✅ C 535/600k M 511/577k ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 22/22 160s
stm32g0b1nucleo ✅ 30/30 ✅ C 501/511k M 516/511k ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 22/22 120s
adafruit_fruit_jam ✅ 30/30 ✅ C 518/512k M 539/537k 62 KB/s 62 KB/s ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 4.0 Mbit/s ✅ ✅ 22/22 186s
raspberry_pi_pico ✅ 30/30 ✅ C 507/513k M 512/520k 62 KB/s 62 KB/s ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 4.5 Mbit/s ✅ ✅ 22/22 183s
ra4m1_ek ✅ 30/30 ✅ C 507/509k M 511/511k ⚪ ✅ ✅ ⚪ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 22/22 205s
metro_m4_express ✅ 30/30 ✅ C 507/429k M 513/536k ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 22/22 221s
ra6m5_ek ✅ 30/30 ✅ C 8.2/7.9M M 15.8/12M ⚪ ✅ ✅ ⚪ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 16/22 (6 skipped) 219s
lpcxpresso55s69 ✅ 30/30 ✅ C 8.4/8.1M M 31/29.5M ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 95.7 Mbit/s ✅ ✅ 16/22 (6 skipped) 222s
lpcxpresso11u37 ✅ 30/30 ✅ C 507/256k M 499/511k ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ⚪ ✅ ✅ 22/22 220s
nrf52840dk ✅ 30/30 ✅ C 440/509k M 511/511k ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 3.7 Mbit/s ✅ ✅ 22/22 228s
stm32f072disco ✅ 30/30 ✅ C 501/256k M 510/485k ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ⚪ ✅ ✅ 22/22 230s
max32666fthr ❌ 29/30 ✅ C 6.9/13.7M M 21.8/20.9M ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 86.0 Mbit/s ✅ ✅ 16/22 (6 skipped) 233s
stm32f407disco ✅ 30/30 ✅ C 507/496k M 514/514k ✅ ⚪ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 3.9 Mbit/s ✅ ✅ 22/22 229s
stm32u083nucleo ✅ 30/30 ✅ C 513/510k M 531/523k ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 22/22 122s
stm32h743nucleo ✅ 30/30 ✅ C 594/515k M 513/511k ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 4.1 Mbit/s ✅ ✅ 22/22 138s
stm32h743nucleo-DMA ✅ 30/30 ✅ C 548/491k M 644/543k ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 4.5 Mbit/s ✅ ✅ 22/22 138s
ch32v103r_r1_1v0 ✅ 30/30 ✅ C 149/289k M 558/598k ⚪ ✅ ✅ ⚪ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ⚪ ✅ ✅ 22/22 151s
ch32v407_r0 ✅ 30/30 ✅ C 8.8/8.3M M 14.9/11.3M ⚪ ✅ ✅ ⚪ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 16/22 (6 skipped) 148s
stm32l476disco ✅ 30/30 ✅ C 507/511k M 511/511k ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 22/22 221s
ch582m_evt ✅ 30/30 ✅ C 227/180k M 479/481k ⚪ ✅ ✅ ⚪ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 22/22 174s
nrf54lm20dk ✅ 30/30 ✅ C 2.1/4.1M M 7.6/8.1M ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 16/22 (6 skipped) 180s
nanoch32v203-fsdev ✅ 30/30 ✅ C 507/511k M 511/511k ⚪ ✅ ✅ ⚪ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ⚪ ✅ ✅ 22/22 120s
nanoch32v203-usbfs ✅ 30/30 ✅ C 605/605k M 615/541k ⚪ ✅ ✅ ⚪ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ⚪ ✅ ✅ 22/22 108s
ea4088_quickstart ✅ 30/30 ✅ C 507/511k M 512/529k 682 KB/s 681 KB/s ✅ ✅ ✅ ✅ ❌ ❌ ✅ ✅ ✅ ✅ ❌ ✅ ✅ ✅ ✅ ✅ ✅ 22/22 421s
nrf5340dk ✅ 30/30 ✅ C 339/340k M 509/481k ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 3.8 Mbit/s ✅ ✅ 22/22 198s
mimxrt1064_evk ✅ 30/30 ✅ C 23.6/17.5M M 37.4/33.1M 15887 KB/s 4002 KB/s ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 184.6 Mbit/s ✅ ✅ 16/22 (6 skipped) 255s
ch32v307v_r1_1v0-usbhs ✅ 30/30 ✅ C 7.1/8M M 16.6/31.1M ⚪ ✅ ✅ ⚪ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ❌ ✅ ✅ 16/22 (6 skipped) 160s
ch32v307v_r1_1v0-usbfs ✅ 30/30 ✅ C 507/510k M 511/511k ⚪ ✅ ✅ ⚪ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 3.9 Mbit/s ✅ ✅ 22/22 132s
stm32f723disco ✅ 30/30 ✅ C 507/421k M 511/511k 11397 KB/s 3912 KB/s ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 3.9 Mbit/s ✅ ✅ 22/22 395s
stm32f723disco-DMA ✅ 30/30 ✅ C 507/511k M 511/511k 14979 KB/s 3971 KB/s ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ 3.9 Mbit/s ✅ ✅ 22/22 231s

⚡ SystemView performance — HIL

base 9f4eb56420 (exact) → PR 45f9696c9

raspberry_pi_pico — live 17.1 s

device/cdc_msc · raspberry_pi_pico-sysview · SYSVIEW=4 buffer 65536 · all events · workload cdc_burst r1 15 s · OpenOCD RTT channel 1

metric base PR Δ
ISR 21 p50 / p99 9.0 / 16.0 / 31.0 µs 9.0 / 18.0 / 31.0 µs — / +12.5%
usbd_edpt_xfer p50 11.0 µs 11.0 µs —
tud_task p50 9.0 µs 9.0 µs —
tud_cdc_read p50 24.0 µs 24.0 µs —
dcd_edpt_xfer p50 6.0 µs 6.0 µs —
tud_cdc_write_flush p50 5.0 µs 5.0 µs —
mscd_xfer_cb p50 20.0 µs 20.0 µs —
CPU load, workload win (ISR 21) 1.7 % 1.8 % —
xychart-beta
    title "hot functions p50 µs (base vs PR)"
    x-axis [usbd_edpt_xfer, task, cdc_read, edpt_xfer, cdc_write_flush, mscd_xfer_cb]
    y-axis "µs" 0 --> 31.2
    bar [11.0, 9.0, 24.0, 6.0, 5.0, 20.0]
    bar [11.0, 9.0, 24.0, 6.0, 5.0, 20.0]
Loading

stm32f407disco — live 17.1 s

device/cdc_msc · stm32f407disco-sysview · SYSVIEW=4 buffer 65536 · all events · workload cdc_burst r1 15 s · OpenOCD RTT channel 1

metric base PR Δ
ISR 83 p50 / p99 7.3 / 10.5 / 13.7 µs 7.3 / 10.5 / 13.7 µs — / —
tud_task p50 4.6 µs 4.6 µs —
tud_cdc_read p50 10.3 µs 10.3 µs —
tud_cdc_write_flush p50 2.6 µs 2.6 µs —
mscd_xfer_cb p50 15.2 µs 15.2 µs —
usbd_edpt_xfer p50 9.9 µs 9.9 µs —
dcd_edpt_xfer p50 5.9 µs 5.9 µs —
CPU load, workload win (ISR 83) 1.5 % 1.7 % +0.2 pt
xychart-beta
    title "hot functions p50 µs (base vs PR)"
    x-axis [task, cdc_read, cdc_write_flush, mscd_xfer_cb, usbd_edpt_xfer, edpt_xfer]
    y-axis "µs" 0 --> 19.8
    bar [4.6, 10.3, 2.6, 15.2, 9.9, 5.9]
    bar [4.6, 10.3, 2.6, 15.2, 9.9, 5.9]
Loading

Legend — p50/p99: median / 99th-percentile duration over all calls in the capture window (µs; p50 = typical cost, p99 = tail latency). Δ: change vs base branch; − is faster/better; +∞% marks a jump from an (effectively) zero base -- not literally infinite, just too big to express as a normal percentage; gone marks a row base had that PR does not (work that used to run no longer does, or was renamed -- investigate before merging). pt: percentage points. CPU load, workload win: context's busy share summed from the raw scheduling events over the workload window (the span of tud_cdc_read activity -- the throughput test's own footprint); falls back to the whole-recording share, labelled as such. stack high-water: peak bytes of stack used. Function rows/bars are ordered by CPU occupancy (calls × p50) in the PR capture, hottest first; base-only rows sort after them. – ⚠︎: metric withheld — RTT ring overflowed (overflow N), no timestamp frequency (no time base), or too few samples (n<50 for p50; p99 needs n>100 for the tail estimate to be statistically meaningful, so it can show n=<n> even on a row whose p50 is shown); withheld beats wrong. Durations read p50 / p99 / max, all as captured — spliced CALL/RET pairs are discarded upstream and counted in dropped_pairs.

@HiFiPhile
HiFiPhile merged commit bec54fc into master Nov 21, 2026
330 of 332 checks passed
@HiFiPhile
HiFiPhile deleted the windows-precommit-fixes branch November 21, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant