Repository navigation
Conversation
gricha
force-pushed
the
ref/sa-user-id-replays
branch
from
October 29, 2026 16:25
71764fc to
1915c09
Compare
Contributor
Sentry Snapshot Testing
|
gricha
force-pushed
the
ref/sa-user-id-replays
branch
from
October 29, 2026 18:30
1915c09 to
11f7cf1
Compare
This was referenced Oct 29, 2026
gricha
force-pushed
the
ref/sa-user-id-replays
branch
from
October 29, 2026 18:49
11f7cf1 to
4fd544b
Compare
gricha
force-pushed
the
ref/sa-user-id-replays
branch
from
October 29, 2026 22:27
4fd544b to
17ca70a
Compare
gricha
changed the base branch from
ref/request-principal-interface
to
ref/sa-user-id-workflows
October 29, 2026 22:27
This was referenced Oct 29, 2026
gricha
force-pushed
the
ref/sa-user-id-replays
branch
from
October 29, 2026 22:39
17ca70a to
48fb21a
Compare
gricha
force-pushed
the
ref/sa-user-id-replays
branch
from
October 29, 2026 23:26
48fb21a to
1533d6f
Compare
This was referenced Oct 29, 2026
gricha
force-pushed
the
ref/sa-user-id-replays
branch
from
October 29, 2026 23:53
1533d6f to
3ae48c4
Compare
gricha
force-pushed
the
ref/sa-user-id-replays
branch
from
October 30, 2026 04:09
3ae48c4 to
c903b74
Compare
gricha
force-pushed
the
ref/sa-user-id-replays
branch
from
October 30, 2026 05:06
c903b74 to
b8c03e7
Compare
A ServiceAccountPrincipal's request.user.id is a ServiceAccountId, which raises UserRequired when used as a user id. has_viewed and viewed-by on replay details now read acting_user_id(request.user), so a service account isn't recorded as a viewer.
gricha
force-pushed
the
ref/sa-user-id-replays
branch
from
October 30, 2026 05:21
b8c03e7 to
9a90a5a
Compare
gricha
force-pushed
the
ref/sa-user-id-replays
branch
from
October 30, 2026 06:37
9a90a5a to
42c4747
Compare
gricha
marked this pull request as ready for review
October 30, 2026 06:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
ServiceAccountPrincipalis authenticated but has no user, and itsidis aServiceAccountIdthat raisesUserRequiredwhen used as a user id.has_viewedand viewed-by on replay details readrequest.user.id. They now callacting_user_id(request.user), so a service account isn't recorded as a viewer instead of getting a 403user-required.Nothing changes for users and agents.
Split out so the owning team can review its slice.
Matrix: fixes 1 service-account row (known gaps 69 → 68). The row is
OrganizationReplayDetails; locally it also fails for every credential on an objectstore error, so CI is the check.Stack (each PR is based on the one above it):
request.userinterfacerequest.user/request.auththrough one helperrequest.userhas_user()in access, org lookups andusers/merequires_user/require_user()serialize_generic_user