Merge pull request #1055 from flippercloud/spec-dead-lets-2

Remove more unused spec setup

Author: dpep

spec/flipper/api/v1/actions/feature_spec.rb

@@ -1,7 +1,5 @@
 RSpec.describe Flipper::Api::V1::Actions::Feature do
   let(:app) { build_api(flipper) }
-  let(:feature) { build_feature }
-  let(:gate) { feature.gate(:boolean) }
 
   describe 'get' do
     malformed_queries = {

spec/flipper/api/v1/actions/features_spec.rb

@@ -1,6 +1,5 @@
 RSpec.describe Flipper::Api::V1::Actions::Features do
   let(:app) { build_api(flipper) }
-  let(:feature) { build_feature }
   let(:admin) { double 'Fake Fliper Thing', flipper_id: 10 }
 
   describe 'get' do

spec/flipper/cloud/telemetry/submitter_spec.rb

@@ -128,18 +128,4 @@
       expect(subject.backoff_policy.retries).to eq(3)
     end
   end
-
-  def with_telemetry_debug_logging(&block)
-    output = StringIO.new
-    original_logger = cloud_configuration.logger
-
-    begin
-      cloud_configuration.logger = Logger.new(output)
-      block.call
-    ensure
-      cloud_configuration.logger = original_logger
-    end
-
-    output.string
-  end
 end

spec/flipper/ui/actions/settings_spec.rb

@@ -1,16 +1,4 @@
 RSpec.describe Flipper::UI::Actions::Settings do
-  let(:token) do
-    if Rack::Protection::AuthenticityToken.respond_to?(:random_token)
-      Rack::Protection::AuthenticityToken.random_token
-    else
-      'a'
-    end
-  end
-
-  let(:session) do
-    { :csrf => token, 'csrf' => token, '_csrf_token' => token }
-  end
-
   describe 'GET /settings' do
     before do
       get '/settings'

spec/flipper/ui/decorators/gate_spec.rb

@@ -1,8 +1,6 @@
 require 'flipper/ui/decorators/gate'
 
 RSpec.describe Flipper::UI::Decorators::Gate do
-  let(:source)  { {} }
-  let(:adapter) { Flipper::Adapters::Memory.new(source) }
   let(:flipper) { build_flipper }
   let(:feature) { flipper[:some_awesome_feature] }
   let(:gate) { feature.gate(:boolean) }