You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix Calendar re-checking access every minute without a grant
#1925
I'd like to fix a small Calendar bug I found in my own Mac's logs.
Tinycast was writing "XPC connection was invalidated" to the system log every minute. It turns out that when Calendar is switched on but macOS hasn't actually granted access, Tinycast re-checks access on every minute tick and gets nowhere.
In my case it happened because Calendar was still on from before the bundle ID change, but the permission stayed with the old ID. I wrote up the details in #1923. I already opened #1922 before I noticed the vouch step, sorry about that.
How do you plan to do it?
It's a one-line change in CalendarStore.reload(). The last checked time gets set before the access check instead of after it. Without a grant, Tinycast then checks again every ten minutes, on wake, at the day change, and whenever the palette opens.
The only downside is that if you grant access in System Settings while the palette is closed, it can take up to 10 mins to show up. I tested it on the dev build and compared the logs before and after.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
What do you want to work on?
I'd like to fix a small Calendar bug I found in my own Mac's logs.
Tinycast was writing "XPC connection was invalidated" to the system log every minute. It turns out that when Calendar is switched on but macOS hasn't actually granted access, Tinycast re-checks access on every minute tick and gets nowhere.
In my case it happened because Calendar was still on from before the bundle ID change, but the permission stayed with the old ID. I wrote up the details in #1923. I already opened #1922 before I noticed the vouch step, sorry about that.
How do you plan to do it?
It's a one-line change in CalendarStore.reload(). The last checked time gets set before the access check instead of after it. Without a grant, Tinycast then checks again every ten minutes, on wake, at the day change, and whenever the palette opens.
The only downside is that if you grant access in System Settings while the palette is closed, it can take up to 10 mins to show up. I tested it on the dev build and compared the logs before and after.
I confirm that:
All reactions