You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(fuselage): EmailInput lets a spread type override type="email" #42811
EmailInput renders <InputBox type="email" {...props} />. Its props type omits type, but a spread from a wider-typed object bypasses excess-property checks, so the input can render as another type. The other typed inputs probably share this pattern.
Suggested fix
Put type="email" after the spread, and check the other typed inputs.
Context
Found by cubic while reviewing #42763, which moved @rocket.chat/fuselage into this monorepo. The behavior is unchanged from Fuselage 0.96.0, so it was out of scope there.
Hi, I'd like to work on this. EmailInput, NumberInput, SearchInput, TextInput, UrlInput and PasswordInput all set type on InputBox before the props spread, so I'd move it after the spread in each one and add tests that a passed type can't override it.
Activity
schizophrenicmaniac commentedon Oct 15, 2026
Hi, I'd like to work on this. EmailInput, NumberInput, SearchInput, TextInput, UrlInput and PasswordInput all set type on InputBox before the props spread, so I'd move it after the spread in each one and add tests that a passed type can't override it.