Repository navigation
Compile launch argument handling once for all argument counts - #745
Merged
Merged
Conversation
The `call` generator used tuples to build its argument list, triggering compilation for each new argument count. Move this work to a vector-based helper that compiles once. This cuts ~30 ms from the first launch with a new argument count on an Arc A770.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
==========================================
- Coverage 86.89% 86.64% -0.25%
==========================================
Files 55 55
Lines 5090 4996 -94
==========================================
- Hits 4423 4329 -94
Misses 667 667 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
callgenerator used tuples to build arguments foronecall, triggering compilation for each new argument count. Move this work tocall_arguments, a vector-based helper with@nospecializearguments that compiles once. The generated code is unchanged.First launch of a new kernel on an Arc A770, Julia 1.12.7, KernelAbstractions 0.10.3. Median of 3 fresh processes, each measuring the median over 6 kernels:
@oneapi, new argument count@oneapi, argument count seen beforeUses the approach from JuliaGPU/KernelAbstractions.jl#931 for PoCL's generator.
The full test suite passes on an Arc A770 (Julia 1.12.7).