Repository navigation
Require SPIRVIntrinsics 1.5.1 for local union arrays - #740
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
==========================================
- Coverage 86.84% 86.37% -0.47%
==========================================
Files 56 55 -1
Lines 5123 4984 -139
==========================================
- Hits 4449 4305 -144
- Misses 674 679 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
maleadt
force-pushed
the
tb/local-union-stride
branch
from
October 24, 2026 15:48
d56bfbf to
83f597f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local arrays of
Union{Int64,NTuple{3,Int32}}need a 16-byte element stride, but SPIRVIntrinsics 1.5.0 allocates only 12 bytes per element. Require 1.5.1, which fixes the allocation, now that oneAPI's union arrays use the aligned stride.The regression test exchanges elements between work-items through local memory and checks that four elements reserve 68 bytes, including their selector bytes. The allocation check fails with 1.5.0 (52 bytes), even though the kernel's result happens to pass on the tested driver.
Tested on an Arc A770: all 254 tests in
test/unions.jlpass on Julia 1.10.12 and 1.13.2 with SPIRVIntrinsics 1.5.1.Fixes #737.