Skip to content

Avoid invalidations in ranktest! - #33

Merged
eloualiche merged 2 commits into
FixedEffects:mainfrom
matthieugomez:fix-invalidations
Nov 16, 2026
Merged

eloualiche merged 2 commits into
FixedEffects:mainfrom
matthieugomez:fix-invalidations

Conversation

@matthieugomez

@matthieugomez matthieugomez commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

ranktest! takes the square root of u_sub * u_sub' from a real eigendecomposition (sqrt(::Matrix) infers as real-or-complex), and converts S_hat's result to Matrix{Float64}, so its solves are concretely typed and CSV dependencies no longer invalidate it.

With CSV loaded, the first reg in FixedEffectModels drops from 0.58s to 0.12s with no recompilation (together with FixedEffects.jl#92 and FixedEffectModels.jl#288). F_kp is unchanged (identical up to 2e-16). Bumps the version to 0.8.6.

@codecov-commenter

codecov-commenter commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.82%. Comparing base (5985964) to head (f7c466d).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/ranktest.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   94.40%   93.82%   -0.59%     
==========================================
  Files           6        7       +1     
  Lines         161      178      +17     
==========================================
+ Hits          152      167      +15     
- Misses          9       11       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matthieugomez matthieugomez changed the title Avoid invalidations in ranktest! and multiway clustering Avoid invalidations in ranktest! Nov 16, 2026
@eloualiche
eloualiche merged commit 1bc5ac7 into FixedEffects:main Nov 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants