Repository navigation
Avoid invalidations in ranktest! - #33
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
- Coverage 94.40% 93.82% -0.59%
==========================================
Files 6 7 +1
Lines 161 178 +17
==========================================
+ Hits 152 167 +15
- Misses 9 11 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
matthieugomez
force-pushed
the
fix-invalidations
branch
from
November 16, 2026 13:21
6eeafa3 to
f7c466d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ranktest!takes the square root ofu_sub * u_sub'from a real eigendecomposition (sqrt(::Matrix)infers as real-or-complex), and convertsS_hat's result toMatrix{Float64}, so its solves are concretely typed and CSV dependencies no longer invalidate it.With CSV loaded, the first
regin FixedEffectModels drops from 0.58s to 0.12s with no recompilation (together with FixedEffects.jl#92 and FixedEffectModels.jl#288).F_kpis unchanged (identical up to 2e-16). Bumps the version to 0.8.6.