Repository navigation
Conversation
🦋 Changeset detectedLatest commit: f7c9dc1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Reviewed the request registration, synchronous-delay reentrancy, pooled-batch reuse, and regression tests. No confirmed merge-blocking issues found. git diff --check passed. Runtime tests were not rerun because dependencies and the repository’s package manager are not installed in the sandbox.
Reviewed at 6fbfaf1: no new findings.
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
There was a problem hiding this comment.
Reviewed the source changes and regression coverage; no confirmed issues found. git diff --check passed. Runtime tests and type checks could not be run: frozen-lockfile dependency installation failed with a registry 403 for @jsr/db__redis and a supply-chain policy check failure.
Reviewed at f7c9dc1: no new findings.
Summary
Register the first request in a batch before starting its delay, so a synchronously completing delay (for example
RequestResolver.setDelay(0)underTestClock) no longer executes and recycles an empty batch. The delay fiber is published from inside the delay effect so reentrant callbacks that fill the batch can interrupt it, and the caller checks that the batch is still pending before touching it. The execution fiber is no longer written back into a batch that may already have been recycled.Tests
Four cases added to
packages/effect/test/Request.test.ts: the TestClock regression with its live-clock control, reentrant delay callbacks filling abatchN(2)batch, and delay, collection and interruption ordering across pooled batch reuse.Validation
pnpm vitest run packages/effect/test/Request.test.ts: 38 passedpnpm lint-fix,pnpm checkandgit diff --checkpassCloses EFF-2352
Related historical report: #7589 and closed, unmerged PR #7597. Separate from #9401.